Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7632, when getting user info in UserCountry dimensions, set language using request object. #7713

Merged
merged 2 commits into from Apr 21, 2015

Conversation

diosmosis
Copy link
Member

Currently uses visitor object, which will not contain the correct language, since the Country dimension will be triggered before the Lanuage one.

Includes a system test.

Refs #7632

…guage using request object not visitor object, since the Country dimension will be triggered before the Lanuage one. Includes test.
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 20, 2015
@diosmosis diosmosis added this to the Piwik 2.13.0 milestone Apr 20, 2015
diosmosis added a commit that referenced this pull request Apr 21, 2015
Fixes #7632, when getting user info in UserCountry dimensions, set language using request object instead of Visitor object since Language dimension is processed after Country.
@diosmosis diosmosis merged commit c821c6c into master Apr 21, 2015
@diosmosis diosmosis deleted the 7632_lang_query_param_geolocation branch April 21, 2015 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants