Tracker optimizations #7711
Merged
Tracker optimizations #7711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 19, 2015 21:49
…I to Monolog plugin and only use logging in tracker if [Tracker] debug = 1.
…ntil run is saved, so the method call does not appear in output.
…after setProfilingRunIds.
| @@ -6,9 +6,11 @@ | |||
|
|
|||
| return array( | |||
|
|
|||
| 'Psr\Log\LoggerInterface' => DI\object('Monolog\Logger') | |||
| 'Monolog\Logger' => DI\object('Monolog\Logger') | |||
There was a problem hiding this comment.
It's a detail but FYI this is the same as 'Monolog\Logger' => DI\object() (no need to fix)
There was a problem hiding this comment.
Good to know, wouldn't have guessed that!
|
👍 looks good |
diosmosis
added a commit
that referenced
this pull request
Apr 21, 2015
Refs #7640, optimize tracker by making sure production tracker does not use a real logger. Includes change to ContainerFactory that allows plugins to provide environment specific DI config & introduces the tracker.php DI environment. Moved logging related config in cli.php environment config to Monolog container. Also has update to php-di.
mattab
added
the
Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7640
This pull request sets the logger used in the tracker to the NullLogger, unless
[Tracker] debugis set to 1.Also includes the following changes:
Here is a profiling run of the tracker w/ these changes: https://blackfire.io/profiles/6a5f3c65-cbf5-48c9-99d3-c28faaedb38a/graph