Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the referrer spam list to a separate repository #7706

Merged
merged 9 commits into from Apr 21, 2015
Merged

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Apr 19, 2015

See #7674

The referrer spam blacklist has been moved to https://github.com/piwik/referrer-spam-blacklist

This PR integrates the new repository using Composer.

The next step would be to auto-update the list, and let users provide their own list in a tmp/spammers.txt file for example. Since auto-updating has security implications it might not happen for 2.13.

@mnapoli mnapoli added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 19, 2015
@mnapoli mnapoli added this to the Piwik 2.13.0 milestone Apr 19, 2015
@mnapoli mnapoli added the Needs Review PRs that need a code review label Apr 19, 2015
/**
* Filters out tracking requests issued by spammers.
*/
class SpamFilter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we rename class to ReferrerSpam since it's only a subset of possible Spam filtering

@mattab
Copy link
Member

mattab commented Apr 21, 2015

Looks good to me - this will help the community and us at Piwik to maintain together an up to date Spam Referrers database!

mattab pushed a commit that referenced this pull request Apr 21, 2015
Moved the referrer spam list to a separate repository
@mattab mattab merged commit b321b19 into master Apr 21, 2015
@mnapoli mnapoli deleted the spam-blacklist branch April 21, 2015 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants