Use HTML 5 download attribute to detect download links (#7663) #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Help wanted
| // links containing a download attribute are always downloads | ||
| equal( tracker.hook.test._getLinkType('test', 'index.html', false, true), 'download', 'download attribute' ); | ||
| equal( tracker.hook.test._getLinkType('piwik_link', 'index.html', true, true), 'link', messagePrefix + ' download attribute, but link class' ); | ||
| equal( tracker.hook.test._getLinkType('piwik_download', 'test.pdf', true, true), 'download', messagePrefix + ' download attribute' ); |
There was a problem hiding this comment.
not sure here but maybe the test returns download because the href is a file name - so maybe change test.pdf to not-a-known-file.xyz or so
There was a problem hiding this comment.
Doesn't make a difference. download extensions are overwritten a few lines above, so pdf shouldn't be recognized as download
|
Nice feature! left a comment otherwise looks good to me! |
mattab
pushed a commit
that referenced
this pull request
Apr 22, 2015
Use HTML 5 download attribute to detect download links (#7663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #7663