Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SitesManager.getPatternMatchSites returns limited set of sites #7700

Closed
RMastop opened this issue Apr 17, 2015 · 2 comments
Closed

SitesManager.getPatternMatchSites returns limited set of sites #7700

RMastop opened this issue Apr 17, 2015 · 2 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.15.0

Comments

@RMastop
Copy link
Contributor

RMastop commented Apr 17, 2015

The API call SitesManager.getPatternMatchSites returns a max of 15 results.
I expected to get all sites matching the pattern
@tsteur
Copy link
Member

tsteur commented Apr 21, 2015

👍 Currently it uses the max value of the config setting site_selector_max_sites and autocomplete_min_sites but it should just return all by default. Note when removing the hard coded limit in that API we need to adjust the websites selector and send a filter_limit with every request.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 14, 2015
@mattab mattab added this to the 2.15.0 milestone Jul 14, 2015
@mattab
Copy link
Member

mattab commented Jul 14, 2015

Thanks for the report @RMastop

@tsteur tsteur self-assigned this Jul 29, 2015
tsteur added a commit that referenced this issue Jul 29, 2015
@tsteur
refs #7700 return all websites my default for API method Sites.getPat…
4b545e5 
…ternMatchSites
@tsteur tsteur mentioned this issue Jul 29, 2015
Merged
tsteur added a commit that referenced this issue Aug 13, 2015
@tsteur
refs #7700 return all websites my default for API method Sites.getPat…
19a191a 
…ternMatchSites
diosmosis added a commit that referenced this issue Aug 24, 2015
@diosmosis
Merge pull request #8459 from piwik/7700
53ec7bd 
Fixes #7700, return all websites my default for API method SitesManager.getPatternMatchSites and specify explicit limit in site selector directive. Includes new limit query parameter in SitesManager.getPatternMatchSites API used instead of filter_limit in order to keep the API method fast when there are tens or hundreds of thousands of sites.
@gamanet gamanet mentioned this issue Jan 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @RMastop