Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace Plugin blocks are too big in some cases #7695

Closed
mattab opened this issue Apr 17, 2015 · 7 comments
Closed

Marketplace Plugin blocks are too big in some cases #7695

mattab opened this issue Apr 17, 2015 · 7 comments
Assignees
@mnapoli
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
2.13.0

Comments

@mattab
Copy link
Member

mattab commented Apr 17, 2015

Here is an example of a Marketplace page rendered:

marketplace looks wrong

Because of the PerformanceInfo plugin that has 2 yellow boxes and has a tall box, all other plugin boxes are tall as well

We expect to see instead the plugin blocks less high such as in this example:

normal
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Apr 17, 2015
@mattab mattab added this to the Piwik 2.13.0 milestone Apr 17, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Apr 17, 2015

In the "before" screenshot, here is what the PerformanceInfo plugin looked like:

image

Do we want to restore the old buggy display? Or what else should we do instead?

@diosmosis
Copy link
Member

In the "before" screenshot, here is what the PerformanceInfo plugin looked like:

Was this change merged? The admin page still looks like this for me.

@mnapoli
Copy link
Contributor

mnapoli commented Apr 19, 2015

For me it looks good right now on master:

capture d ecran 2015-04-19 a 22 51 23

@diosmosis
Copy link
Member

This is what I see on Firefox:

marketplace_bug

It looks ok on chrome.

@mnapoli
Copy link
Contributor

mnapoli commented Apr 19, 2015

ah yeah I can reproduce in smaller screens (on Firefox and Chrome), I'll fix it!

mnapoli added a commit that referenced this issue Apr 19, 2015
@mnapoli
#7695 Fix the display of plugin boxes in the marketplace
d519e1f
@mnapoli
Copy link
Contributor

mnapoli commented Apr 19, 2015

It should now display correctly.

@mattab
Copy link
Member Author

mattab commented Apr 20, 2015

To make the box less high we would need to remove the yellow notifications from the plugin box. I'm closing this issue as "wontfix" for now and let's think about it during Marketplace redesign in #7586 (comment)

@mattab mattab closed this as completed Apr 20, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Apr 20, 2015
@mnapoli mnapoli self-assigned this Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
3 participants
@diosmosis @mattab @mnapoli