All websites dashboard - improve performance when thousands of websites #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $result[$key] = $this->createOrderedIndex($metadataNamesToIndexBy); | ||
| if (empty($metadataNamesToIndexBy)) { | ||
| foreach ($indexKeyValues as $key) { | ||
| $result[$key] = array(); |
There was a problem hiding this comment.
Note to myself, use array_fill_keys or so
tsteur
changed the title
tsteur
force-pushed
the
6809_2
branch
2 times, most recently
from
ad55d37
to
acb5271
Compare
| @@ -157,21 +161,65 @@ public function useSubtable($idSubtable) | |||
| */ | |||
| public function make($index, $resultIndices) | |||
| { | |||
| $keyMetadata = $this->getDefaultMetadata(); | |||
There was a problem hiding this comment.
A lot of time was spent in setting and transforming metadata. This is much faster now. Eg before we did set a table metadata like array('period' => '2012-12...', 'site' => 5) and they were afterwards "transformed" to array('period' => Period, 'site' => new Site()).
| $keyMetadata[$resultIndex] = new Site($label); | ||
| } elseif ($resultIndex === DataTableFactory::TABLE_METADATA_PERIOD_INDEX) { | ||
| $keyMetadata[$resultIndex] = $this->periods[$label]; | ||
| } |
There was a problem hiding this comment.
Small code clarity item: I think this might be clearer in a private method, ie, $keyMetadata[$resultIndex] = $this->createTableIndexMetadata($resultIndex, $label);
…it again later once needed
|
Needs a rebase & then +1 to merge it before the beta/RC |
mattab
pushed a commit
that referenced
this pull request
Apr 22, 2015
All websites dashboard - improve performance when thousands of websites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6809
This improves the performance of the All Websites Dashboard. It includes improvements on several layers:
MultiSites.getAlltwice whenever the websites dashboard was loaded. One to get the current dashboard and one request to get the previous one (this was needed for a hover tooltip, thepast_data.total.nb_visits). We do now only one request as theMultiSites.getAllalready always requested the past data anyway. I do now expose this total visits value as wellMultiSites.getAllon the server much faster. Eg before it took easily > 300 seconds to perform oneMultiSites.getAllrequest when having 33k sites. This is now done in less than 10 seconds. If only a few sites are archived, and browser archiving is disabled, the performance improved from > 60 seconds to < 5 seconds. Basically a problem was that we first created eg 100K DataTables, 1mio Rows, ... just to merge them afterwards together viamergeChildrento 1 DataTable and 33k Rows. This took a long time. Instead we want to directly build the merged dataTable. There are many changes in this pull request and each of them has actually a huge impact on MultiSites.getAll performance.