Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website selector: searching for special strings will show html code #7692

Closed
mattab opened this issue Apr 17, 2015 · 2 comments
Closed

Website selector: searching for special strings will show html code #7692

mattab opened this issue Apr 17, 2015 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Apr 17, 2015

Reproduce:

  • in a website selector, with 10 websites or so,
  • enter in the search field an (or any substring of `...........
  • notice that the autocompleter will highlight in purple some text but it actually displays html code of the element, as can be seen in this screenshot:

highlighter

Expected behavior would be that the html code is not displayed (and that the highlighter / search does not match on the html text but only on the text without markup)

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Apr 17, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Apr 20, 2015

Ah I reported that here: #7552 (comment) but apparently I forgot to fix it ;)

What do you say I just remove the color highlighting? I remember looking into it and it was a mess because of escaping issues.

@mattab
Copy link
Member Author

mattab commented Apr 20, 2015

color highlighting is actually useful: it shows user why the website name matches the search (which sometimes is not obvious when website names are long or when search string is short).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants