Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt-out iframe not shown in Firefox when included from another domain #7689

Closed
florianjacob opened this issue Apr 16, 2015 · 2 comments
Closed

opt-out iframe not shown in Firefox when included from another domain #7689

florianjacob opened this issue Apr 16, 2015 · 2 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@florianjacob
Copy link
Contributor

Firefox only shows an empty space instead of the opt-out iframe when loading it from another domain, using piwik 2.12.1 and firefox 37.0.1. Probably a problem with the X-Frame-Options setting, I checked headers with curl -I and it seems like X-Frame-Options is empty for the iframe url, while being set to sameorigin for other urls. Just tried with oxfam.de, same result:

$ curl -I "https://www.oxfam.de/piwik/index.php?module=CoreAdminHome&action=optOut&language=de"
Date: Wed, 15 Apr 2015 21:47:00 GMT
Server: Apache
Cache-Control: no-storPragma: 
Expires:e, must-revalidate
X-Frame-Options: 
[..]
Vary: Accept-Encoding,User-Agent
Content-Type: text/html; charset=utf-8

$ curl -I "https://www.oxfam.de/piwik/index.php"
HTTP/1.1 200 OK
Date: Wed, 15 Apr 2015 21:48:46 GMT
Server: Apache
Cache-Control: no-store, must-revalidate
X-Frame-Options: sameorigin
[..]
Vary: Accept-Encoding,User-Agent
Content-Type: text/html; charset=utf-8
@florianjacob florianjacob mentioned this issue Apr 16, 2015
Closed
@florianjacob
Copy link
Contributor Author

Found the relevant code, it is intentional to send an empty x-frame-options: https://github.com/piwik/piwik/blob/3838/core/View.php#L244

Not sure whether the empty X-Frame-Options is the actual reason for firefox not displaying the iframe, though.

@florianjacob
Copy link
Contributor Author

Found the solution: It's not Firefox, it's the adblocker filter lists I use there, which also contain generic matches for urls starting with piwik. TIL.

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @florianjacob