Prevent useless ajax requests in live widgets (fixes #7404) #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Help wanted
|
How about using this alternative to test if the element is in the DOM: http://stackoverflow.com/a/3086084/245552 I'm not sure performance matter that much here but the suggested solution is 2 orders of magnitude faster so why not. |
|
I'll check/test that tomorrow |
|
changed! |
|
👍 |
mnapoli
added a commit
that referenced
this pull request
Apr 16, 2015
Prevent useless ajax requests in live widgets (fixes #7404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #7404.
I've improved the js code of the live widgets to ensure the elements are still present in body before new ajax calls are triggered. Before there were only checks if the element were still kind of present, which was the case, even when not within the body.