New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Search Parameters - extra trailing white space cause no site search tracked #7678
Comments
Hi @futureweb thanks for the suggestion! It makes a lot of sense that when reading the list of parameter we should apply a white space trim. |
In which browser is this happening? I tried to reproduce in latest Chrome and Firefox but couldn't. |
Was tested with latest FF |
Did you have this problem with "Global Websites Settings" or on a specific site? Do you remember when you configured it initially (approx., it would be enough to know like 1 month ago, 6 months ago, ...)? Which Piwik version are you using? Can you maybe try to reproduce it again, and then execute those SQL queries (if possible) and post the output: select * from piwik_option where `option_name` = 'SitesManager_SearchKeywordParameters';
select sitesearch_keyword_parameters from piwik_site; You could change the value back directly afterwards again to make sure it works again. Background: I prepared a possible patch that makes sure that values will be trimmed but I still cannot reproduce it. I would like to be able to reproduce it before we apply this patch. In theory angular should take care of trimming each value as there is a |
Using latest Version, it's configured as Global Setting - never touched since initial Install - which is ago some years. Output for booth Queries: query,searchquery (without Space - even if Space is shown in Output of Configuration Page) |
Perfect, there was probably a bug before we converted it to angular. Cheers |
Hello,
I guess it would make sense to put a trim() around each Site Search Parameter you can configure for specific Sites / default for all Sites.
I had: "query, searchquery" instead of "query,searchquery" (note the Space) - and searchquery was not tracked as internal Site Search ...
As a Space will never occur within an URL it should be stripped away.
Bye from Austria
Andreas Schnederle-Wagner
The text was updated successfully, but these errors were encountered: