Added possibility to profile any command by setting the option --xhprof #7675
Conversation
| 'Enable profiling with XHProf' | ||
| ); | ||
|
|
||
| $this->getDefinition()->addOption($option); |
There was a problem hiding this comment.
Can you add this only if development mode is enabled?
There was a problem hiding this comment.
Nah, you don't want to profile when development mode is enabled... it wouldn't cache, perform extra checks etc.
There was a problem hiding this comment.
In that case, can we echo a warning or throw an exception when trying to profile w/ development mode is enabled (would do this when calling setupProfilerXhprof for the main run)?
There was a problem hiding this comment.
Not sure, we could log a warning and remove it once it becomes a problem. Eg someone might enable development mode on purpose to profile things uncached etc. Adding this logger would be a new issue I reckon as we would need to do this also when using xhprof=1 in a URL.
There was a problem hiding this comment.
Maybe in the summary output (that includes a link to the profile) we can print whether Development mode is enabled, and a note that says nothing is cached and you may want to run w/ it disabled, etc.
|
Can we remove the xhprof param from the core:archive command? |
|
The core:archive does some additional work, eg it does forward the |
|
@tsteur If you rebase/merge, I'll merge the PR. |
tsteur
force-pushed
the
console_profiling
branch
from
9f58dd3
to
5e85665
Compare
Added possibility to profile any command by setting the option --xhprof
No description provided.