Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider HTML5 download attribute #7663

Closed
mnlipp opened this issue Apr 12, 2015 · 2 comments
Closed

consider HTML5 download attribute #7663

mnlipp opened this issue Apr 12, 2015 · 2 comments
Assignees
@sgiehl
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.14.0

Comments

@mnlipp
Copy link

mnlipp commented Apr 12, 2015

In HTML5 we have the "download" attribute for the a-element (http://www.w3.org/TR/html5/links.html#attr-hyperlink-download). It would be nice if piwik handled an a-alement with a "download" attribute automatically as a download. Currently (if the file extension isn't known to piwik) I still have to add "class='piwik_download'" in order to enable proper tracking as download.
@sgiehl
Copy link
Member

sgiehl commented Apr 17, 2015

I think we should implement a automatic detection for that download attribute.

Btw. in the next version it will also be easily possible to add a new download extension (might be easier than adding classes for each link) see #7444

@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Apr 17, 2015
@sgiehl sgiehl self-assigned this Apr 17, 2015
@sgiehl sgiehl added this to the Piwik 2.14.0 milestone Apr 17, 2015
sgiehl added a commit that referenced this issue Apr 18, 2015
@sgiehl
fixes #7663 - consider links with download attribute as downloads
34225cf
@sgiehl sgiehl mentioned this issue Apr 18, 2015
Merged
@mattab
Copy link
Member

mattab commented Apr 20, 2015

Nice idea - didn't hear of this download attribute until now 👍

mattab pushed a commit that referenced this issue Apr 22, 2015
Merge pull request #7703 from piwik/7663_download_attribute
245e5d1 
Use HTML 5 download attribute to detect download links (#7663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
3 participants
@mattab @mnlipp @sgiehl