Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help menu highlighting #7657

Merged
merged 1 commit into from Apr 10, 2015
Merged

Help menu highlighting #7657

merged 1 commit into from Apr 10, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Apr 10, 2015

#7642

@mattab this is to fix the bug you noticed here: #7642 (comment)

It took some debugging to realize what was happening… I don't know what to do with that code so I just added that hack, if you see a better solution feel free to suggest.

@mnapoli mnapoli added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 10, 2015
@mnapoli mnapoli added this to the Piwik 2.13.0 milestone Apr 10, 2015
@mnapoli mnapoli changed the title A try at fixing the top menu highlighting when on the help page Help menu highlighting Apr 10, 2015
@mnapoli mnapoli mentioned this pull request Apr 10, 2015
Closed
@mattab
Copy link
Member

mattab commented Apr 10, 2015

looks good to me

mattab pushed a commit that referenced this pull request Apr 10, 2015
Merge pull request #7657 from piwik/help-link
d32ade5 
Help menu highlighting
@mattab mattab merged commit d32ade5 into master Apr 10, 2015
@mnapoli mnapoli deleted the help-link branch April 10, 2015 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnapoli @mattab