New design for the maintenance mode #7648
Conversation
mnapoli
added
not-in-changelog
|
the visual looks good to me, a solid improvement! (I didn't look at code) |
|
FYI the diff is huge because this PR is based on the other PR which is also based on another PR :) But the commit is very simple: 71c7a7d |
| </div> | ||
|
|
||
| <div class="logo"> | ||
| <img title="Piwik" alt="Piwik" src="plugins/Morpheus/images/logo-header.png"/> |
There was a problem hiding this comment.
Should we show a possible custom logo here?
There was a problem hiding this comment.
Added support for custom logos in the updater too (in #7578).
mnapoli
force-pushed
the
redesign-maintenance
branch
from
c0e86c9
to
9a35c16
Compare
| $logo = new CustomLogo(); | ||
| $logoUrl = $logo->getHeaderLogoUrl(); | ||
| $faviconUrl = $logo->getPathUserFavicon(); | ||
| } catch (Exception $ex) { |
There was a problem hiding this comment.
+1 - I tested that maintenance is displayed correctly when DB is not accessible and it works thanks to this catch (case where the DB could be down during maintenance)
|
Keep in mind while reviewing that this PR is based on #7578, only the 2 last commits are about the maintenance. |
…ftware/), it may not be free as in beer - by removing those titles we remove some possible confusion (eg. we don't show "Free Web Analytics" on the login form on Piwik Cloud)
|
|
It now uses |
New design for the maintenance mode
|
@mattab I'm afraid the commits are not good here :/ I was rebasing this PR because as you can see the diff includes some commits of the updater redesign, which is not good. I don't know if there are any consequences. Only the 2 last commits should have been merged. |
Fixes #7620
Pull request based on #7578, don't merge this one before merging #7578.
Current design:
There's not much to say in that page so it feels a bit empty…