Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Help link to top menu #7642

Closed
mattab opened this issue Apr 8, 2015 · 2 comments
Closed

Add Help link to top menu #7642

mattab opened this issue Apr 8, 2015 · 2 comments
Assignees
@mnapoli
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.13.0

Comments

@mattab
Copy link
Member

mattab commented Apr 8, 2015

Currently Help page is available via the Top user menu > Help. It was suggested to add the Help link to the top menu for direct access.

Follows up #7637
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Apr 8, 2015
@mattab mattab added this to the Piwik 2.13.0 milestone Apr 8, 2015
@mattab mattab mentioned this issue Apr 8, 2015
Merged
@mnapoli mnapoli self-assigned this Apr 9, 2015
@mnapoli mnapoli closed this as completed in cf7ed86 Apr 9, 2015
mattab added a commit that referenced this issue Apr 9, 2015
@mattab
show top menu only when plugin activated refs #7642
84791a5
@mattab
Copy link
Member Author

mattab commented Apr 10, 2015

I noticed a little issue:

  • when the Help link is clicked,
  • Got: on page reload it highlights in top menu the User menu.
  • Expected: to have highlight on Help instead.

reproduce URL: http://demo.piwik.org/index.php?module=Feedback&action=index&idSite=1&period=day&date=yesterday

@mattab mattab reopened this Apr 10, 2015
mnapoli added a commit that referenced this issue Apr 10, 2015
@mnapoli
#7642 A try at fixing the top menu highlighting when on the help page
f2f1bf1
@mnapoli mnapoli mentioned this issue Apr 10, 2015
Merged
@mnapoli
Copy link
Contributor

mnapoli commented Apr 10, 2015

Good catch! I have the enterprise admin locally which overrides the link, so I tested with and without but obviously not enough!

See #7657

@mnapoli mnapoli closed this as completed Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli