Do not pre-process segments for period=range #7635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when "date to load by default" is "last 7|30 days" and we pre-process those ranges, we don't want to pre-process segments as it is not needed. this can avoid thousands of extra archiving requests when Piwik server has dozens or hundreds of segments setup
mattab
added
not-in-changelog
|
Is it possible to write a test for this? Would be good as the CronArchive is a huge mess :) Eg in |
|
it could be possible with further refactor but i'm not able to right now (sorry) |
mattab
pushed a commit
that referenced
this pull request
Apr 9, 2015
Do not pre-process segments for period=range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when "date to load by default" is "last 7|30 days" and we pre-process those ranges, we don't want to pre-process segments as it is simply not needed.
this can avoid thousands of extra archiving requests when Piwik server has dozens or hundreds of segments setup.
(this performance regression was introduced in #6856)
fixes #7611