@tsteur opened this Pull Request on April 7th 2015 Owner

fixes #3838 #4476

@tsteur commented on April 7th 2015 Owner

Failing UIIntegrationTest_api_listing is expected since there are new parameters. No clue why this one fails which has a 0.00% mismatch: http://builds-artifacts.piwik.org/ui-tests.3838/11517.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/SitesManager_page_1.png&expected=SitesManager_page_1.png&github=SitesManager_page_1.png Background: I expect SitesManager_page_1.png in two tests: https://github.com/piwik/piwik/pull/7634/files#diff-515ed8ae9c608910163e301ac2816902R47 and https://github.com/piwik/piwik/pull/7634/files#diff-515ed8ae9c608910163e301ac2816902R60

@diosmosis do you maybe have an idea why the 0.00% mismatch would fail?

@diosmosis commented on April 7th 2015 Member

Not sure what's causing the test failure, is it consistent or random? The test runner should only fail if the percentage in the comparison != 0, see https://github.com/piwik/piwik/blob/master/tests/lib/screenshot-testing/support/chai-extras.js#L148

Does the test output display the mismatch percentage found in travis? I can't remember if I put that in. EDIT: nevermind it's the line after the one I linked :)

@tsteur commented on April 7th 2015 Owner

It is consistent. I reckon I will simply test against two different images instead of using the same. Maybe the difference is < 0.01%? not sure what happens then...

@tsteur commented on April 7th 2015 Owner

After merge we need to update translations in oTrance

@mnapoli commented on April 17th 2015 Contributor

Needs a rebase and then :+1: for merge

@mattab commented on April 17th 2015 Owner

awesome to have scalable UI for Website Manager!

created follow up issue: Website Manager small UX and design tweaks #7696

This Pull Request was closed on April 17th 2015
Powered by GitHub Issue Mirror