Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide how we keep official plugins from calling non-public APIs or deprecated code #7633

Open
mattab opened this issue Apr 7, 2015 · 2 comments
Open

Decide how we keep official plugins from calling non-public APIs or deprecated code #7633

mattab opened this issue Apr 7, 2015 · 2 comments
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Apr 7, 2015

The goal of this issue is to find a way to automatically notify Product team when any plugin has outdated code.

Why is it needed?

Proposal

  • maybe our code inspection could send an email to the team,
  • or maybe we could create a new CI job for Plugins CI build that would fail, when the latest plugin code inspection has detected some bad code for this plugin (eg. it would fetch the report over http://builds-artifacts and if it exists for this plugin, fail the CI job)
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Apr 7, 2015
@diosmosis
Copy link
Member

To safely assume that plugins don't get broken by Core platform changes, we need to automatically detect/ be notified of calls to deprecated functions or non-public APIs.

Note: the PHPStorm plugin can be installed on developers' PHPStorm so they can see issues as they code. (would have to enable the inspection & would be a problem w/ plugins that don't support the newest Piwik)

@mattab mattab added this to the Short term milestone Apr 8, 2015
@mattab mattab mentioned this issue Apr 10, 2015
Closed
@mattab mattab changed the title How to notify Product engineering team when an official Plugin calls non-public APIs or deprecated code? Decide how we keep offiial plugins from calling non-public APIs or deprecated code Apr 10, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Apr 10, 2015
@mattab mattab changed the title Decide how we keep offiial plugins from calling non-public APIs or deprecated code Decide how we keep official plugins from calling non-public APIs or deprecated code Apr 10, 2015
@diosmosis diosmosis mentioned this issue Aug 26, 2015
Closed
@mattab
Copy link
Member Author

mattab commented Nov 17, 2015

FYI: sensiolabs created a static code analysis tool to find usages of deprecated methods https://github.com/sensiolabs-de/deprecation-detector - this could maybe be interesting to us in the future

@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@diosmosis @mattab