Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to edit a goal #7631

Closed
wants to merge 1 commit into from
Closed

Link to edit a goal #7631

wants to merge 1 commit into from

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Apr 6, 2015

Fixes #7345

capture d ecran 2015-04-06 a 13 12 55

@mnapoli mnapoli added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 6, 2015
@mnapoli mnapoli added this to the Piwik 2.13.0 milestone Apr 6, 2015
@mattab
Copy link
Member

mattab commented Apr 7, 2015

Feedback

  • did you try to write (edit goal) instead of the icon? otherwise it may feel like "icons overload" (it was discussed in issue)

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 7, 2015

Yes I tried and it looked weird and overloaded. In the issue there are no reasons given why not to use icons, maybe there's another issue somewhere where it's discussed?

@mattab
Copy link
Member

mattab commented Apr 9, 2015

it doesnt look awesome, but it's a small part of the app, and it's a useful shortcut to let users edit goals, so +1

maybe others have suggestions?

@diosmosis
Copy link
Member

I think some text would be useful, otherwise I wouldn't assume the icon is for editing goal, so much as editing for the header text.

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 9, 2015

I'll work on a solution with a text link + a screenshot

@diosmosis
Copy link
Member

Nice goal, btw :)

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 10, 2015

Comparing the 2 options:

capture d ecran 2015-04-06 a 13 12 55

capture d ecran 2015-04-10 a 17 21 41

Any other idea?

@diosmosis
Copy link
Member

Not sure how it would look, but maybe a right aligned link that says (edit goal) or (edit goal details)?

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 10, 2015

Aligned to the right of the screen? Here the screenshot is truncated but on a large screen it would be really far from the title (all alone on the right).

@diosmosis
Copy link
Member

That's what I was thinking of (far to the right). This may not apply to others, but associating an edit link with the title for goal reports, rather than something directly related to the goal seems odd to me. I'm not a UX expert though.

Maybe <small>ed and surrounded with () and left aligned? Just spitballing here.

@tsteur
Copy link
Member

tsteur commented Apr 17, 2015

What about the suggestion of @Bugsbane in #7345 (comment) . He suggested to add a menu link "Manage Goals" before "Add a new Goal". Reckon this would be most clear and visible.

@mattab
Copy link
Member

mattab commented Apr 17, 2015

add a menu link "Manage Goals" before "Add a new Goal". Reckon this would be most clear and visible.

+1 - not sure why we didn't do it in the first place

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 17, 2015

OK closing this then

@mnapoli mnapoli closed this Apr 17, 2015
@mnapoli mnapoli deleted the edit-goal branch April 21, 2015 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants