Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes overlapping issue in visitor log (see #7089) #7630

Merged
merged 1 commit into from Apr 9, 2015
Merged

Fixes overlapping issue in visitor log (see #7089) #7630

merged 1 commit into from Apr 9, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 5, 2015

This PR aims to fix #7089

As the number counter weren't positioned very good at all, I've moved them in front of the action, so they can directly be seen

the problem:
visitor_log_profile_link_overlaps

Before:
image

After:
image

@sgiehl sgiehl added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review labels Apr 5, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Apr 5, 2015

👍 nice little fix

@mattab
Copy link
Member

mattab commented Apr 7, 2015

looks good to me

@tsteur
Copy link
Member

tsteur commented Apr 7, 2015

Nice!

@mattab mattab added this to the Piwik 2.13.0 milestone Apr 8, 2015
mattab pushed a commit that referenced this pull request Apr 9, 2015
Merge pull request #7630 from piwik/issue_7089
f4c0178 
Fixes overlapping issue in visitor log (see #7089)
@mattab mattab merged commit f4c0178 into master Apr 9, 2015
@mattab
Copy link
Member

mattab commented Apr 9, 2015

a UX fix well done

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 10, 2015
@sgiehl sgiehl deleted the issue_7089 branch April 10, 2015 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgiehl @mnapoli @mattab @tsteur