Allow removing download extensions (fixes #7444) #7629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feedback
|
mattab
added
the
not-in-changelog
|
I've added some tests. |
|
looks good to me, merging 👍 |
mattab
pushed a commit
that referenced
this pull request
Apr 9, 2015
Allow removing download extensions (fixes #7444)
|
Hi @sgiehl, just remembered we didn't update the developer documentation at: https://github.com/piwik/developer-documentation/blob/master/docs/tracking-javascript.md - would you mind documenting the new method there? |
|
Sorry. I somehow thought the documentation is some kind of autogenerated. I've updated the doc in matomo-org/developer-documentation@1794b90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #7444 and adds the possibility to exclude an extension from the list of "download extensions".
It also converts the list of already excluded extensions into an array and resolves the regexes to single values, so it is possible to remove only some of them.
Methods for setting, adding and removing extensions now accept single values as well as multiple values (as array or separated by "|")