Update to device detector 3.1.1 #7627
Conversation
sgiehl
added
the
Pull Request WIP
|
Some tests are currently failing due to an detection "improvement" in device detector. That is because the malformed useragents given from log import are not recognized in any way anymore. Imho caused by matomo-org/matomo-log-analytics#59 |
| <label>Phablet</label> | ||
| <nb_visits>0</nb_visits> | ||
| <segment>deviceType==phablet</segment> | ||
| <logo>plugins/DevicesDetection/images/screens/unknown.gif</logo> |
There was a problem hiding this comment.
maybe we could find an icon for Phablets?
There was a problem hiding this comment.
@mattab there are also other icons for device types missing. Imho it would be cool to have icons, that fit in the theme and that share the same look-alike. Do you think we could get nice icons for all device types from a designer?
There was a problem hiding this comment.
Ok makes sense - maybe we can create an issue for this design project and I'll see if designers could help with icons (we also discuss to maybe use font awesome which may have icons for some of those devices #7618)
There was a problem hiding this comment.
there would be one for mobile, tablet and car but I don't think we would find everything in font awesome. Btw. I think it's difficult to find good icons that show a visible different between tablet and phablet...
|
As matomo-org/matomo-log-analytics#59 is fixed, tests are working again as expected. Can be reviewed and merged now. (UI screenshots need to be updated) |
sgiehl
added
Needs Review
|
Looks good to me; merging. |
Update device detector dependency to 3.1.1
No description provided.