Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny: visitor profile: linebreak between value and unit #7608

Open
hpvd opened this issue Apr 1, 2015 · 4 comments
Open

tiny: visitor profile: linebreak between value and unit #7608

hpvd opened this issue Apr 1, 2015 · 4 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@hpvd
Copy link

hpvd commented Apr 1, 2015

tiny: visitor profile: linebreak between value and unit
seen in 2.13 b1
please see attachment
2015-04-01_10h53_41

@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Apr 8, 2015
@mattab mattab added this to the Mid term milestone Apr 8, 2015
@saleemkce
Copy link
Contributor

It has nothing to do with line break because it always depends on screen resolution/size. Even if you use "
UNIT VALUE" pattern, for smaller or wider resolutions, it will put this pattern in new line and would seem like a TEXT break. I have faced this issue too many times in the past. One possible solution would be like using a UI label like this
"Task", "c:Design/UI" as seen above using HTML label field which will ensure nice UI and automatically prevents line breaks for any "UNIT VALUE" patterns.

@hpvd
Copy link
Author

hpvd commented Apr 9, 2015

sounds interesting.
Maybe one should collect all cases/places where this could happen within this ticket?

From image above one could see that these are not only simple ones "UNIT VALUE" but also
"VALUE1 UNIT1 VALUE2 UNIT2" e.g. for durations like "3 hours 29 min" which should be protected from being split.

@saleemkce
Copy link
Contributor

Yes, that's exactly what I too thought. We need to fix this in all the occurrences possible so that uniformity is maintained throughout the site and such key metrics is highlighted by default.

@mnapoli
Copy link
Contributor

mnapoli commented Apr 13, 2015

It could also be fixed with a non-breaking space (  in HTML).

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

4 participants