Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate Piwik environment creation (including DI container creation) in single class #7601

Closed
diosmosis opened this issue Mar 31, 2015 · 2 comments
Assignees
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@diosmosis
Copy link
Member

This will make it possible to store more objects in DI, making testing easier/cleaner, and we will also be able to get rid of StaticContainer (eventually).

Current plan is to encapsulate environment creation within a Bootstrap class, and use it in new classes that encapsulate application entry points (ie, tracker/normal web requests/archive.php script/console etc.).

@diosmosis diosmosis added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Mar 31, 2015
@diosmosis diosmosis added this to the Short term milestone Mar 31, 2015
@diosmosis diosmosis assigned diosmosis and mnapoli and unassigned diosmosis Mar 31, 2015
@mattab
Copy link
Member

mattab commented Apr 1, 2015

is this something we're working on this sprint? if so please move it to 2.13.0

@diosmosis diosmosis assigned diosmosis and unassigned mnapoli Apr 2, 2015
@diosmosis diosmosis modified the milestones: Piwik 2.13.0, Short term Apr 2, 2015
mnapoli added a commit that referenced this issue Apr 2, 2015
The container now uses IniFileChain, which means it doesn't need the Config object anymore.
@diosmosis diosmosis modified the milestones: Piwik 2.14.0, Piwik 2.13.0 Apr 17, 2015
@diosmosis
Copy link
Member Author

Fixed in #7644.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants