Memory error in API Live.getLastVisitsDetails when filter_offset is large #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $sql .= " | ||
| LIMIT | ||
| $limit"; | ||
| $sql = $this->appendLimitClauseToQuery($sql, $limit); |
There was a problem hiding this comment.
There was a "bug". The PHPdoc already said it would support a Limit by clause but it only supported a limit number (int). It does now actually support 10, 5 for LIMIT 5 OFFSET 10
…ter_offset is large
| return $data; | ||
| } catch (Exception $e) { | ||
| echo $e->getMessage(); | ||
| exit; |
There was a problem hiding this comment.
This exit was added in 977d059#diff-11527d0f07d21b83277153a2ebb852acR306 but didn't really make sense to me. Maybe it was just the way we handled it back then
tsteur
added
Bug
|
Code and tests look good to me, |
mattab
pushed a commit
that referenced
this pull request
Apr 1, 2015
Memory error in API Live.getLastVisitsDetails when filter_offset is large
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7458
Before, when
LIMIT 10 OFFSET 15was requested we did fetch 25 records from the database to make sure theSortandLimitfilter in GenericFilter works.Now we do directly in the API apply
filter_limitandfilter_offsetto fetch only 10 records. This means we do no longer supportSortfor theLive.getLastVisitsDetailsAPI method. As the method name says we will always sort byvisit_last_action_time.filter_sort_orderwill still work.