Visible subtableId in system tests #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them from the response
tsteur
added
Task
it's normal I think, most tests calling API with sub-tables use |
mattab
pushed a commit
that referenced
this pull request
Mar 31, 2015
Visible subtableId in system tests
|
good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that subtableIds are consecutive in each serialized DataTable we could test for them in the API output of system tests. Not sure if it has any downsides apart from breaking existing tests of other plugins etc since the subtable would show now. Are there any?
I was surprised not more tests actually contain a subtableId. Maybe something is missing?