New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design for Installer screens #7584
Comments
List of pull requests:
|
Everything has been merged (except icons), I think we can close this one! |
Re-opening (rather than creating new issue), as I have little feedback:
|
Fixed, except the one related to checkboxes: I believe there is a JS somewhere that replaces the radio/checkboxes with some other HTML that creates a styled radio/checkbox. For example for a radio: <input type="radio" name="foo"> gets replaced with: <div class="form-radio" style="position: relative;">
<input type="radio" name="foo" value="today" style="position: absolute; opacity: 0;">
<ins class="iCheck-helper" style="position: absolute; top: 0%; left: 0%; display: block; width: 100%; height: 100%; margin: 0px; padding: 0px; border: 0px; opacity: 0; background: rgb(255, 255, 255);"></ins>
</div> This JS isn't loaded during the installation (because that only loads the base CSS I guess), so that's why checkboxes are not styled. I don't know if it's a lot of work/if it's worth it, what do you think? Regarding this: I also think it doesn't look very good. The problem is that form inputs are supposed to take 50% of the width, making exception isn't easy especially since the form is built using QuickForm (so I can't even put the long description in a form help div). I want to get rid of QuickForm since it's limiting and it's only used in the installation, but that requires work… |
sounds good, let's leave them un-styled.
Maybe we can tackle this (removing quickform) if really this is what is blocking us from styling these in the installer. it's on the mid term goal to remove code in
+1 it would look perfect |
@mnapoli what is the next step, could this issue be closed? |
This issue isn't finished as the feedback you listed isn't fixed yet. |
The goal of this issue is to refresh the design of the Piwik installer screens.
Here is an example of the new design for the "Installation" screens:
Another example:
Note: in this issue the scope is only restricted to changes in the design (html/css) and not any text or feature.
What do you think about these designs?
The text was updated successfully, but these errors were encountered: