Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for Installer screens #7584

Closed
mattab opened this issue Mar 31, 2015 · 10 comments
Closed

New design for Installer screens #7584

mattab opened this issue Mar 31, 2015 · 10 comments
Assignees
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 31, 2015

The goal of this issue is to refresh the design of the Piwik installer screens.

Here is an example of the new design for the "Installation" screens:

piwik-step1

Another example:

piwik-step2

Note: in this issue the scope is only restricted to changes in the design (html/css) and not any text or feature.

What do you think about these designs?

@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Mar 31, 2015
@mattab mattab added this to the Short term milestone Apr 8, 2015
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Apr 8, 2015
@mattab mattab modified the milestones: Short term, Piwik 2.14.0 Apr 9, 2015
@mnapoli mnapoli self-assigned this Apr 29, 2015
mnapoli added a commit that referenced this issue May 10, 2015
@mnapoli
Copy link
Contributor

mnapoli commented May 10, 2015

The complete screenshot list:

step1
step2
step3
step4
step5
step6
step7
step8
step9

@mnapoli
Copy link
Contributor

mnapoli commented May 21, 2015

List of pull requests:

@mnapoli
Copy link
Contributor

mnapoli commented Jun 4, 2015

Everything has been merged (except icons), I think we can close this one!

@mnapoli mnapoli closed this as completed Jun 4, 2015
@mattab
Copy link
Member Author

mattab commented Jun 8, 2015

Re-opening (rather than creating new issue), as I have little feedback:

  • Some Next buttons are big, some are small. In installer, can we make all Next buttons consistently big?
  • can we style checkboxes in the installer?
  • for the two checkboxes at the bottom of form, maybe the label could be made not to wrap to another line?

checkboxes not styles

  • final step of installer: checkboxes are not styled - maybe they can be styled better?

looks random

@mattab
Copy link
Member Author

mattab commented Jun 8, 2015

  • When "Reusing the tables" was successful, do we want to show this green tick icon, or maybe show the text as a "success" notification?

reusing the tables success

@mnapoli
Copy link
Contributor

mnapoli commented Jun 10, 2015

Fixed, except the one related to checkboxes: I believe there is a JS somewhere that replaces the radio/checkboxes with some other HTML that creates a styled radio/checkbox. For example for a radio:

<input type="radio" name="foo">

gets replaced with:

<div class="form-radio" style="position: relative;">
    <input type="radio" name="foo" value="today" style="position: absolute; opacity: 0;">
    <ins class="iCheck-helper" style="position: absolute; top: 0%; left: 0%; display: block; width: 100%; height: 100%; margin: 0px; padding: 0px; border: 0px; opacity: 0; background: rgb(255, 255, 255);"></ins>
</div>

This JS isn't loaded during the installation (because that only loads the base CSS I guess), so that's why checkboxes are not styled. I don't know if it's a lot of work/if it's worth it, what do you think?

Regarding this:

I also think it doesn't look very good. The problem is that form inputs are supposed to take 50% of the width, making exception isn't easy especially since the form is built using QuickForm (so I can't even put the long description in a form help div). I want to get rid of QuickForm since it's limiting and it's only used in the installation, but that requires work…

@mattab
Copy link
Member Author

mattab commented Jun 10, 2015

This JS isn't loaded during the installation (because that only loads the base CSS I guess), so that's why checkboxes are not styled. I don't know if it's a lot of work/if it's worth it, what do you think?

sounds good, let's leave them un-styled.

I want to get rid of QuickForm since it's limiting and it's only used in the installation, but that requires work…

Maybe we can tackle this (removing quickform) if really this is what is blocking us from styling these in the installer. it's on the mid term goal to remove code in libs/ folder so removing libs/HTML sounds good. Btw it's used in the Installation also for: Login form and Privacy manager form (FormDefaultSettings).

[...] put the long description in a form help div

+1 it would look perfect

@mattab
Copy link
Member Author

mattab commented Jun 16, 2015

@mnapoli what is the next step, could this issue be closed?

@mnapoli
Copy link
Contributor

mnapoli commented Jun 16, 2015

This issue isn't finished as the feedback you listed isn't fixed yet.

@mattab
Copy link
Member Author

mattab commented Jun 20, 2015

End of install form was styled (in #8135)

look good

in general I think the install looks great now 👍 ☀️

(any tweak let's maybe note in #8157)

@mattab mattab closed this as completed Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants