Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include certificates for update over HTTPS? #7580

Closed
mnapoli opened this issue Mar 30, 2015 · 5 comments
Closed

Include certificates for update over HTTPS? #7580

mnapoli opened this issue Mar 30, 2015 · 5 comments
Assignees
@mnapoli
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.13.0

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Mar 30, 2015

It seems some systems do not have certificates installed, which makes the update over HTTPS fail. See this comment: http://forum.piwik.org/read.php?2,125605,page=1#msg-125613

It seems to be a minority of users (for the forum posts). Should we include those certificates in Piwik by default? @mattab what do you think?

(let's discuss this assuming the "update over HTTP" fallback work, i.e. those users still have the possibility to update with HTTP)
@mnapoli mnapoli added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Mar 30, 2015
@mnapoli mnapoli added this to the Piwik 2.13.0 milestone Mar 30, 2015
@mnapoli mnapoli mentioned this issue Mar 30, 2015
Closed
@mattab
Copy link
Member

mattab commented Mar 30, 2015

it's valuable to let users on Windows and other systems without default setup certificates, upgrade Piwik over SSL - so +1 in general

@bolera
Copy link

bolera commented Apr 1, 2015

Actually, setting the CA path via php.ini is easy as was demonstrated by the user who reported the problem and who fixed it himself. But it seems on some systems there are problems with the location. Maybe people should choose a different location than putting it in the root of C:\ There might be permission issues.

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 1, 2015

@bolera for those users we could include the certificate file so it would solve any problem they might have on their system.

@mnapoli mnapoli self-assigned this Apr 6, 2015
mnapoli added a commit that referenced this issue Apr 6, 2015
@mnapoli
#7580 Piwik now includes certificates so that updating over HTTPS wor…
1c0a0a8 
…ks even if the local PHP install doesn't have root certificates installed

This new file is included by `Piwik\Http::configCurlCertificate()`
@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 6, 2015

I imported a root certificates file in Piwik, should work on PHP installs that don't have any root certificate set up.

@mnapoli mnapoli closed this as completed Apr 6, 2015
@mattab
Copy link
Member

mattab commented Jun 22, 2015

Btw: noticed Guzzle also includes the cacert file, in case we wanted to re-use their file and not bundle it ourselves.

// name -> file size
  '/vendor/guzzle/guzzle/src/Guzzle/Http/Resources/cacert.pem' => 250394,
  '/core/DataFiles/cacert.pem' => 249822,

@tassoman tassoman mentioned this issue Jan 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
3 participants
@mattab @mnapoli @bolera