Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New design for the updater #7578

Merged
merged 8 commits into from Apr 17, 2015
Merged

New design for the updater #7578

merged 8 commits into from Apr 17, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Mar 30, 2015

Fixes #7450 (redesign of the updater).

This PR is based on #7481 (Bootstrap grid system). Since the idea of including Bootstrap as a whole doesn't seem to go well (#7390) this redesign wasn't easy and doesn't look as good as it could (see screenshots below). To avoid struggling too much I have copy-pasted some standard Bootstrap classes (e.g. notifications, base button classes, etc..) as I needed. Still far from perfect as it doesn't work everywhere…

Below are screenshots of the current screens. I will keep them up to date if the pull request is updated.

A new version is available

Current:

New:

capture d ecran 2015-03-30 a 16 57 08

HTTPS download fail

Current:

New:

capture d ecran 2015-03-30 a 16 57 18

HTTP download fail

capture d ecran 2015-03-30 a 16 57 29

Update success

Current:

New:

capture d ecran 2015-03-30 a 16 57 48

DB update

Current:

New:

screenshot1

DB update error

capture d ecran 2015-04-02 a 15 53 47

DB update success

Current:

New:

capture d ecran 2015-04-07 a 17 35 52

Error page

Current:

New:

capture d ecran 2015-04-02 a 15 54 40

The stack trace is only displayed here because it's dev environment, don't pay attention to it.

@mnapoli mnapoli added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Mar 30, 2015
@mnapoli mnapoli added this to the Piwik 2.13.0 milestone Mar 30, 2015
@mnapoli mnapoli mentioned this pull request Mar 30, 2015
Closed
@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 2, 2015

I have pushed a new update regarding:

  • db updater
  • exception pages

Exception pages use the same "simple layout" so I applied the same redesign so that it's consistent. I have updated the screenshots in the issue description above, please have a look at them.

This was referenced Apr 2, 2015
Closed
Closed
@mattab
Copy link
Member

mattab commented Apr 7, 2015

Feedback

  • DB update success: remove grey box around donation and make text look like other text in the Update screens
  • Otherwise looks good to me! 👍

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 7, 2015

Thanks, I have tweaked the "DB update success" screen to remove the box display for the donation. Not perfect but better than before (the donation part is in a Twig template + its own CSS that is included in other parts of Piwik).

Screenshot updated.

@mnapoli mnapoli mentioned this pull request Apr 9, 2015
Merged
@mnapoli mnapoli added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Apr 12, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 12, 2015

By the way I forgot to remove the tags but this change is ready for review and merge. But #7481 must be merged first as this PR is based on it

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 13, 2015

Note: updated the PR to add support for custom logos (whitelabel) in the updater.

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 16, 2015

I've rebased on master now that the Bootstrap branch has been merged and that I updated the screenshots.

The UI tests now show the redesigned screens.

@mattab
Copy link
Member

mattab commented Apr 17, 2015

The UI tests now show the redesigned screens.

it's very cool to be able to visualise the changes in this way... and it looks very good to me! 👍

(we didn't include icons from the mockup and we will decide how to handle icons in general in #7618)

mattab pushed a commit that referenced this pull request Apr 17, 2015
Merge pull request #7578 from piwik/redesign-updater
adb2504 
New design for the updater
@mattab mattab merged commit adb2504 into master Apr 17, 2015
@mnapoli mnapoli deleted the redesign-updater branch April 17, 2015 03:09
@mattab mattab mentioned this pull request Apr 20, 2015
Closed
10 tasks
@mattab mattab mentioned this pull request Jun 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnapoli @mattab @diosmosis