@diosmosis opened this Issue on March 29th 2015 Member

Now that there is a report for plugins that use deprecated/non-API symbols, we should fix the problems it reports. This can be done either by updating the plugin or exposing more symbols as <a class='mention' href='https://github.com/api'>@api</a>.

Follows up https://github.com/piwik/piwik/issues/6539 & Refs #7633

@mattab commented on March 29th 2015 Member
@diosmosis commented on May 24th 2015 Member

Problem with this ticket: Many PRO plugins are only updated when the pro team decides to update the Piwik version used on cloud. This means, if we need to change the plugin to do things a different way, the change may not appear in master for a long time. So it may not be possible to complete this issue.

@mattab commented on May 24th 2015 Member

@diosmosis I'm trying to think of a solution to this issue. Is the problem that the inspection runs against master and maybe should run against develop instead for those plugins that have a develop branch? (would this solve the issue, or if not, do you have an idea of a solution)

@diosmosis commented on May 24th 2015 Member

That would solve part of the issue, however, if the PRO team doesn't incorporate the changes (maybe because they want to wait until they are ready to update to the next Piwik version), it won't help.

We could create issues on the repos, but I can't think of a way to deal w/ all the inspection failures w/o waiting a while.

@mattab commented on May 24th 2015 Member

We could create issues on the repos, but I can't think of a way to deal w/ all the inspection failures w/o waiting a while.

I see. It's OK if it takes few days or weeks to merge those PR and have code inspection all green. Let's say that our goal here is to create those Pull requests for all repositories with inspection failures, so that when all such Pull requests will ultimately be merged, there will be no inspection failure left.

@mattab commented on June 16th 2015 Member

Moving to 3.0.0 - we haven't yet made much progress on this issue unfortunately, but I hope before 3.0.0 we can ensure plugins only use public API code :+1:

Powered by GitHub Issue Mirror