Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove and/or fix all uses of non-API & deprecated methods/fields/classes/interfaces in maintained plugins #7569

Closed
diosmosis opened this issue Mar 29, 2015 · 6 comments
Closed

Remove and/or fix all uses of non-API & deprecated methods/fields/classes/interfaces in maintained plugins #7569

diosmosis opened this issue Mar 29, 2015 · 6 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Priority Backlog ...

Comments

@diosmosis
Copy link
Member

Now that there is a report for plugins that use deprecated/non-API symbols, we should fix the problems it reports. This can be done either by updating the plugin or exposing more symbols as @api.

Follows up #6539 & Refs #7633
@diosmosis diosmosis added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Mar 29, 2015
@diosmosis diosmosis mentioned this issue Mar 29, 2015
Closed
@diosmosis diosmosis removed the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 29, 2015
@mattab
Copy link
Member

mattab commented Mar 29, 2015

Report is available behind password to team members at: http://builds-artifacts.piwik.org/protected/inspections.all/2015-03-29/inspections/all_inspections.out

@mattab mattab added this to the Piwik 2.14.0 milestone Mar 29, 2015
This was referenced Apr 7, 2015
Closed
Open
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Apr 8, 2015
mnapoli added a commit that referenced this issue Apr 24, 2015
@mnapoli
#7569 Simplified Piwik\Timer class + tests
1cecd8b
mnapoli added a commit that referenced this issue Apr 24, 2015
@mnapoli
#7569 Move the Timer class into a new Piwik\Timer namespace + tag it …
2624632 
…as API
@mnapoli mnapoli mentioned this issue Apr 24, 2015
Closed
mnapoli added a commit to matomo-org/plugin-VisitorGenerator that referenced this issue Apr 24, 2015
@mnapoli
matomo-org/matomo#7569 Use the new Timer class that is now marked as API
29048c3
@mnapoli mnapoli mentioned this issue Apr 24, 2015
Closed
This was referenced Apr 28, 2015
Closed
Open
@diosmosis
Copy link
Member Author

Problem with this ticket: Many PRO plugins are only updated when the pro team decides to update the Piwik version used on cloud. This means, if we need to change the plugin to do things a different way, the change may not appear in master for a long time. So it may not be possible to complete this issue.

@mattab
Copy link
Member

mattab commented May 24, 2015

@diosmosis I'm trying to think of a solution to this issue. Is the problem that the inspection runs against master and maybe should run against develop instead for those plugins that have a develop branch? (would this solve the issue, or if not, do you have an idea of a solution)

@diosmosis
Copy link
Member Author

That would solve part of the issue, however, if the PRO team doesn't incorporate the changes (maybe because they want to wait until they are ready to update to the next Piwik version), it won't help.

We could create issues on the repos, but I can't think of a way to deal w/ all the inspection failures w/o waiting a while.

@mattab
Copy link
Member

mattab commented May 24, 2015

We could create issues on the repos, but I can't think of a way to deal w/ all the inspection failures w/o waiting a while.

I see. It's OK if it takes few days or weeks to merge those PR and have code inspection all green. Let's say that our goal here is to create those Pull requests for all repositories with inspection failures, so that when all such Pull requests will ultimately be merged, there will be no inspection failure left.

mattab pushed a commit that referenced this issue Jun 3, 2015
Merge pull request #7790 from piwik/7569_new_apis
2bffd11 
Refs #7569 mark some methods/classes w/ @api
@mattab mattab mentioned this issue Jun 3, 2015
Merged
@mattab
Copy link
Member

mattab commented Jun 16, 2015

Moving to 3.0.0 - we haven't yet made much progress on this issue unfortunately, but I hope before 3.0.0 we can ensure plugins only use public API code 👍

@mattab mattab modified the milestones: 3.0.0, 2.14.0 Jun 16, 2015
@mattab mattab mentioned this issue Aug 13, 2015
Closed
@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 21, 2019
@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@diosmosis @mattab @sgiehl