Refs #7560, avoid array to string conversion notice in DistributedList & descendents. #7562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t & descendents. Throws exception instead so a stack trace can be found.
diosmosis
added
Bug
mattab
pushed a commit
that referenced
this pull request
Mar 29, 2015
Refs #7560, avoid array to string conversion notice in DistributedList & descendents.
mattab
added
the
not-in-changelog
| $item = (string)$item; | ||
| foreach ($items as $key => &$item) { | ||
| if (is_array($item)) { | ||
| throw new \InvalidArgumentException("Array item encountered in DistributedList::setAll() [ key = $key ]."); |
There was a problem hiding this comment.
maybe it's worth dumping the array in the logger as well ?
(note: i've already merged PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws exception instead so a stack trace can be found.
@mattab Can you review? I can't reproduce the exact issue, and there's no stack trace in the error report, so maybe this isn't the best solution.
Refs #7560