New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log which segments are currently being archived #7536
Comments
It would be also good to have information what is currently being processed. Now we get information only about last task and we don't know what is in progress. |
currently it displays the log before the archiving request, can you give
an example if there is an issue?
|
@quba we had a look with @mattab and there is a maybe a quick win we can do: showing progress of current requests (when there are many segments). For example:
Would that be a progress from the current situation? The problem is that a better solution (e.g. showing the name of the segments) would require much more work because we need to do extensive changes to how the archiving work. So in the meantime we try to find a simpler solution that could help. |
@mnapoli I had an idea on how we could log as suggested in issue description: instead of sending all segment URLs to CliMulti at once, we could create chunks of |
Yes but that would make the feature of CliMulti to chunk and parallelize obsolete, so do we remove multi-threading from the CliMulti to put it in CronArchive? And if we do that that's still not easy as we need to find a way to keep trace of the segment (or message) from the moment we list the segments and add them to the url list, and the moment we iterate through that url list to query each one of them. I.e. same problem as today except we stay in the same class (and add more logic to cronarchive). It's possible, but I don't think it's especially easier or cleaner than another solution. |
Quick change for this would be to add callbacks to CliMulti so we can execute code when an archiving job is about to be executed. |
I have a POC that has this output:
|
It looks good to me 👍 here is an idea: add |
PR: #7723 |
The goal of this issue is to do a small improvement the core:archive log,
Currently the core:archive output looks like:
Will pre-process for website id = 2, range period, the following 10 segments: { pageUrl!=xx, segment2here, segment3here, segment4here, .... }
the log line can get very long....
The idea would be to have an output like this:
Note: by default 3 segments will be triggered at once (
--concurrent-requests-per-website=3
). if a website has eg. 100 segments, it would issue 34 requests or so. This simple log statement change will really improve the experience to Piwik administrators!The text was updated successfully, but these errors were encountered: