Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor profile, visits loaded on click are missing the datetime #7522

Closed
mattab opened this issue Mar 24, 2015 · 7 comments
Closed

Visitor profile, visits loaded on click are missing the datetime #7522

mattab opened this issue Mar 24, 2015 · 7 comments
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
2.12.1

Comments

@mattab
Copy link
Member

mattab commented Mar 24, 2015

The goal of this issue is that in a Visitor Profile, when clicking on "Load more visits" the visits loaded should display the date time in the visit header bar.

(should be quick fix, so adding to 2.12.1)

URL to reproduce

See missing visits:
visitor profile visits loaded on click are missing the datetime
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Mar 24, 2015
@mattab mattab added this to the Piwik 2.12.1 milestone Mar 24, 2015
@sgiehl sgiehl self-assigned this Mar 24, 2015
@sgiehl
Copy link
Member

sgiehl commented Mar 24, 2015

I'll have a look at that now.

@sgiehl sgiehl mentioned this issue Mar 24, 2015
Merged
@mattab
Copy link
Member Author

mattab commented Mar 24, 2015

I see in API response:


        <serverDatePrettyFirstAction>Wed 25 Mar</serverDatePrettyFirstAction>
        <serverTimePrettyFirstAction>00:42:20</serverTimePrettyFirstAction>

so maybe we simply display in the template serverDatePrettyFirstAction - serverTimePrettyFirstAction which does not require change to API, what do you think?

@sgiehl
Copy link
Member

sgiehl commented Mar 25, 2015

Thought about that, too ;)
Already had added that to the templates. But within the visitorprofile the date is reformated using https://github.com/piwik/piwik/blob/master/plugins/Live/VisitorProfile.php#L23
If it is ok to use another format at that point, I'll change it.

@mattab
Copy link
Member Author

mattab commented Mar 25, 2015

+1 to change it to make it consistent with API - we might as well consume the "pretty" dates we give to users :)

@sgiehl
Copy link
Member

sgiehl commented Mar 25, 2015

The pretty dates set in the API are not nice to display at that point. The dates would be like "Fr 13 Apr" without a year. Maybe we should change the dates in the API aswell and return a full date.

@RMastop
Copy link
Contributor

RMastop commented Mar 25, 2015

+1 for changing the pretty date into a full date.

@mattab
Copy link
Member Author

mattab commented Mar 25, 2015

+1

@sgiehl sgiehl closed this as completed in b1a7a3b Mar 25, 2015
mattab pushed a commit that referenced this issue Mar 25, 2015
Merge pull request #7525 from piwik/7522
70902a4 
Show missing datetimes in visitor profile (fixes #7522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
2.12.1
Development

No branches or pull requests
3 participants
@mattab @sgiehl @RMastop