Making the formatting of template files consistent with Piwik's styleguide and PSR-2 #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added
not-in-changelog
|
👍 |
|
thanks @sgiehl for answering |
mnapoli
added a commit
that referenced
this pull request
Mar 29, 2015
Making the formatting of template files consistent with Piwik's styleguide and PSR-2
|
See also our follow up issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really minor change but it's been scratching an itch of mine for some time. When we generate code, e.g. a controller, command, API, plugin, etc there are always tiny details off. We might as well have correct formatting from the start :)
Hopefully this PR makes all code template files consistent with Piwik's style guide and PSR-2. I'm opening it as a PR so that we can avoid a revert later if somebody disagrees with a change, let's discuss it now. Else 👍 and it's merged.