Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotting a report w/ all columns or goals view is broken #7506

Open
diosmosis opened this issue Mar 23, 2015 · 3 comments
Open

Pivotting a report w/ all columns or goals view is broken #7506

diosmosis opened this issue Mar 23, 2015 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Comments

@diosmosis
Copy link
Member

If a report is viewed in the All Columns view or the Goals view, and the table is pivotted, the result is incorrect (w/ no data being displayed).

The pivoting itself appears to work (although the resulting datatable is missing the numeral prefixes, which may be expected, I'm not sure). After the pivoting the DataTablePostProcessor::$callbackBeforeGenericFilters function is called which erases all data in the table. The closure that removes the rows is here: https://github.com/piwik/piwik/blob/master/core/Plugin/Visualization.php#L400

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 23, 2015
@mattab
Copy link
Member

mattab commented Mar 23, 2015

If a report is viewed in the All Columns view or the Goals view, and the table is pivotted

Maybe we could improve the Pivot feature and display a Metric selector, that would let user select the metric being pivotted. User could choose between Actions, Actions per visit, Average time on site, Goal 1 Conv rate, etc.

If we don't show the metric selector, then we could just for now "disable" the pivot feature when "All columns" or "Goals" view is selected for a datatable?

@diosmosis
Copy link
Member Author

I think this is a good idea, but I think it's unrelated to the failure.

@mattab
Copy link
Member

mattab commented Apr 8, 2015

so as first step and scope of this issue: let's simply disable this view so the bug cannot be triggered ie. "disable" the pivot feature when "All columns" or "Goals" view is selected (we would re-investigate later when working on #4776 )

@mattab mattab added this to the Short term milestone Apr 8, 2015
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Apr 9, 2015
@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Jul 8, 2016
@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

2 participants