Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pragma "disableCookies" does not work in some browers #7494

Closed
AgnesWhy opened this issue Mar 20, 2015 · 19 comments
Closed

The pragma "disableCookies" does not work in some browers #7494

AgnesWhy opened this issue Mar 20, 2015 · 19 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Privacy For issues that impact or improve the privacy. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@AgnesWhy
Copy link

I have tested the piece of code hereafter including the "diableCookies" pragma respectively in Firefox 36.0 and in Chrome 41.0.2272.89 m
In Firefox, no cookie is installed, while in Chrome, the visitor cookies are installed (i.e.: ses; id, cvar....)

You can reproduce the issue using the site: ShemaleAgnes.com . The pages index.html and tst_dis.html have cookies diabled, the page tst_end has cookies enabled. In Firefox, cookies are only installed when opening the page tst_enb.hml. In Chrome, opening any page will install the cookies. Cookies are also installed when the pragma "diableCookies" is used on all pages for all trackers.

The piece of code used :
QUOTE

<script type="text/javascript"> </script>

UNQUOTE

@svenlewerentz
Copy link

I can confirm this issue. More details here: http://forum.piwik.org/read.php?2,123722

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. c: Privacy For issues that impact or improve the privacy. labels Apr 8, 2015
@mattab mattab added this to the Short term milestone Apr 8, 2015
@mattab
Copy link
Member

mattab commented Apr 8, 2015

Hi guys, thanks for the report.

Increasing priority as it's an important feature to make sure that disableCookies works correctly, this Privacy feature is loved by many Piwik users.

@mattab mattab changed the title The "pragma" "disableCookies" does NOT work in some browers. The pragma "disableCookies" does not work in some browers Apr 8, 2015
@AgnesWhy
Copy link
Author

Could some pick up this problem? It's open for 8 weeks now and it's a quite annoying issue.

@AgnesWhy
Copy link
Author

Apparently, problem has been fixed on version 2.12.0 as I can no longer reproduce it in Google Chrome 42.0.2311.135 m. Could someone else, test it again? Thanks

@mattab mattab modified the milestones: 2.14.0, Short term May 14, 2015
@mattab
Copy link
Member

mattab commented May 20, 2015

Hi @svenlewerentz can you confirm the issue is also fixed for you in 2.13.1 ?

@svenlewerentz
Copy link

I can NOT confirm, that the issue is fixed. I tested with Piwik 2.13.1 and Chrome 43.0.2357.65 m / Windows.
You can check it here: http://www.sven-lewerentz.de

@carbureted
Copy link

It would be great if this could get fixed ASAP - this bug is really obnoxious when combined with EU cookie law.

@AgnesWhy
Copy link
Author

AgnesWhy commented Jun 2, 2015

IMHO the problem is fixed, at least in version 2.12, I have tested it again ysterday in Firefox and Chrome with the instruction "disable cookies" and no "visitor cookie" was installed.

Hello Carbureted, could you please elaborate on on your problem: which version of Piwik, which version of the browser ?

If you want to test it, just visit one of my sites (e.g.: https://ShemaleAgnesEscort.com ) Piwik is called from each and every page and visitor cookies are disabled. Navigate through the site and check whether vistor cookies are installed in any of the browsers you used.

Have a nice day

Agnès

@svenlewerentz
Copy link

@AgnesWhy Could you please check the link, I posted in my last post and report, if there are any piwik-cookies set by my page?
If I visit your site, there are multiple cookies set in chrome. Please check the screenshot:
cookies

Thanks! Sven

@AgnesWhy
Copy link
Author

AgnesWhy commented Jun 2, 2015

Hi Sven,

I have just checked in Chrome Version 43.0.2357.81 m for differetn pages of your site http://www.sven-lewerentz.de/ and no cookie was stored by Piwik. And the same for my site, I have re-checked once more and no cookie was stored by Piwik.
I also checked in the venrable IE 8 with your site and my site and there was no cookie stored by Piwik.
Could it be the problem is linked to some settings of you Chrome version ? But I cannot figure out which ones.

A.

@carbureted
Copy link

I saw cookies on the disconnect.me site (piwik is now disabled) with the no-cookies option selected as of last Friday on the latest version of Chrome. Weirdly, no cookies reported in Firefox. Additionally, the cookies were empty, which is strange.

messages image 1184827456

@tsteur
Copy link
Member

tsteur commented Jun 7, 2015

@AgnesWhy please contact "hello at piwik.org" via email and leave a comment here once you did so we can have a look in the spam folder just in case it goes there

@tsteur tsteur self-assigned this Jun 7, 2015
@tsteur
Copy link
Member

tsteur commented Jun 7, 2015

FYI: I've identified 2 issues so far:

  1. Eg setSiteId() might be executed before disableCookies() causing it to set a cookie initially which should be removed later as soon as a tracking request is performed. This can be fixed "easily" by making sure to execute _paq('disableCookies') very first.
  2. Before any disableCookies is executed we do set a visitorIdCookie already in the constructor. This requires some refactoring and we need to stay BC see https://github.com/piwik/piwik/blob/2.14.0-b1/js/piwik.js#L4095 . Need to investigate about possible options.

@tsteur
Copy link
Member

tsteur commented Jun 8, 2015

I couldn't reproduce it but found some possible edge cases how this can happen.

Can you give this updated piwik.js https://raw.githubusercontent.com/piwik/piwik/c6985edb229abf4a5328fe27d371bd4d01b617f7/piwik.js a try and replace the existing file with the content of the new one?

@svenlewerentz
Copy link

@tsteur
I replaced the piwik.js here: http://www.sven-lewerentz.de
Cookies are still saved in Chrome.

@tsteur
Copy link
Member

tsteur commented Jun 8, 2015

Can you maybe delete all cookies and test again in case you didn't delete them before? It's weird when I open that site with Chrome Version 43.0.2357.81 (64-bit) + Mac OS there are no cookies. Maybe I'm doing something wrong?

@tsteur
Copy link
Member

tsteur commented Jun 8, 2015

@svenlewerentz I just had a look again under Windows + Chrome and during this I noticed it is still using the "old" piwik.js. While testing with the old piwik.js I could reproduce and see cookies once. Here's the link to the "new" piwik.js: https://raw.githubusercontent.com/piwik/piwik/c6985edb229abf4a5328fe27d371bd4d01b617f7/piwik.js Do you mind updating?

In this particular case the cookies were only set to delete potential existing cookies. That's why there was an empty value. This should be fixed with the latest version.

@svenlewerentz
Copy link

@tsteur
Sorry, I made a mistake and replaced the wrong piwik.js in the js-subfolder. Now the correct file should be replaced with yours.
And it seems it works well with your file. No cookies are set.

@tsteur
Copy link
Member

tsteur commented Jun 9, 2015

Sweet. Thanks a lot! Closing the issue.

@tsteur tsteur closed this as completed Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Privacy For issues that impact or improve the privacy. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

5 participants