Moving database connection from static variable to DI + related changes. #7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
Pull Request WIP
|
Hard to review, I reckon it's ok :) |
|
Forget about this PR for now, can do it later when LocalTracker isn't used. |
diosmosis
force-pushed
the
db_in_di
branch
4 times, most recently
from
58e9c0d
to
e201eba
Compare
…me map when displayed on a page
diosmosis
force-pushed
the
db_in_di
branch
2 times, most recently
from
b2e4ef9
to
8c7f816
Compare
added 22 commits
December 29, 2015 11:11
…uired for tracker).
…fetch/query/exec methods to it. Will be used as primary low level DB access API by end of PR.
…o connect to the DB w/o having to go through DI or static methods. Separated DB creation/setup from Fixture::performSetUp.
…b adapter. Fix several (but not all) tests.
… test creates a connection & allow SystemTestCase to check if a database connection has been created through DI config. Has some test fixes, but there are still problems w/ this solution.
…tatable options through DI config instead of in TestingEnvironmentManipulator so DB connection is not automatically created during tests. Also removed the Db\Schema class since it is not needed (only the interface is necessary).
…tion and is required to not be created during tests.
…an AdapterInterface through DI. Add all missing methods to AdapterInterface.
…e to have 0 static methods.
…apterInterface instead of Db\Connection.
…one does not reset the DB config which allows us to reconnect to the DB when needed.
…a resetConfig() call, and quick fix for previous Fixture refactor which is now causing problems.
|
Thank you for this proposed pull request. Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit). We hope you understand this and we look forward to seeing an update from you on this pull request or another one! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, this pull request's purpose is to move the database connection to DI so it can be easily injected.
Includes many other changes since the connection code is highly coupled.
By the end, should include a proof of concept test that mocks the DB connection to test whether OPTIMIZE TABLES is done for MariaDB InnoDB tables.