The menu doesn't intercept middle mouse clicks anymore #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reverting the revert! Revert "Revert "The menu does not intercept middle mouse clicks anymore"" This reverts commit c86d0ba.
mnapoli
added
c: Usability
mnapoli
added a commit
that referenced
this pull request
Mar 29, 2015
The menu doesn't intercept middle mouse clicks anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7466: re-applies the changes of #7478 (which were reverted in master) by reverting the revert (oh yeah) and fixing the problem in the original fix (oh yeah).
The first PR contained a bug: on load a
clickis simulated bymenu.jsand that results in an event object that didn't carry the information of "which button was clicked". Silly me didignore clicks that are not on the left button, so if no button was clicked then the ajax handling was ignored.Let's put this in 2.13.