Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of country name in [lang].json #7479

Closed
ghtiun opened this issue Mar 19, 2015 · 2 comments
Closed

Inconsistent use of country name in [lang].json #7479

ghtiun opened this issue Mar 19, 2015 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.14.0

Comments

@ghtiun
Copy link

ghtiun commented Mar 19, 2015

Certain references to Taiwan are inconsistent in the [lang].json in plugins/UserCountry/lang. For example, the term "Taiwan, Province of China" is used to indicate Taiwan in the tl and en version; while "Republic of China"(Repubblica di Cina) in the it version.

May I suggest simply using "Taiwan" and equivalent word in each language version to make it consistent? Many thanks.
@mnapoli
Copy link
Contributor

mnapoli commented Mar 20, 2015

Related discussion on what StackExchange did: http://meta.stackexchange.com/questions/170143/taiwan-is-not-a-province-of-china

@mattab
Copy link
Member

mattab commented Apr 8, 2015

+1 to change the en.json to use Taiwan as the name

@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Apr 8, 2015
@mattab mattab modified the milestones: Short term, Piwik 2.14.0 Apr 8, 2015
@saleemkce saleemkce mentioned this issue Apr 12, 2015
Closed
@sgiehl sgiehl closed this as completed in 3c3052c Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
3 participants
@mattab @mnapoli @ghtiun