Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getRowsWithoutSummaryRow when iterating over subtables #7476

Merged
merged 1 commit into from Mar 19, 2015
Merged

Use getRowsWithoutSummaryRow when iterating over subtables #7476

merged 1 commit into from Mar 19, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 18, 2015

A summary row does not have a subtable, so we can simply get the rows without summary row and avoid creating many new arrays in getRows(). This improves performance quite a bit.

@tsteur
a summary row does not have a subtable, so we can simply get the rows…
199b7fe 
… without summary row and avoid creating many new arrays
@tsteur tsteur added c: Performance For when we could improve the performance / speed of Matomo. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 18, 2015
@tsteur tsteur added this to the Piwik 2.12.0 milestone Mar 18, 2015
@mattab
Copy link
Member

mattab commented Mar 19, 2015

looks good to me, refs #4768

mattab pushed a commit that referenced this pull request Mar 19, 2015
Merge pull request #7476 from piwik/datatable_getrows_performanceimpr…
5c8e3b2 
…ovement

Use `getRowsWithoutSummaryRow` when iterating over subtables
@mattab mattab merged commit 5c8e3b2 into master Mar 19, 2015
@tsteur tsteur deleted the datatable_getrows_performanceimprovement branch March 19, 2015 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab