Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percentage fix in the "Browser plugin" report #7469

Merged
merged 2 commits into from Mar 18, 2015
Merged

Percentage fix in the "Browser plugin" report #7469

merged 2 commits into from Mar 18, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Mar 18, 2015

Fix for #7437

  • Ignore IE 6-10 from total number of visits (was previously also ignoring IE 11, which caused the wrong percentage)
  • Prevent any percentage in the "Browser plugins" report to be more than 100% (safeguard)

@mnapoli
#7437 Exclude all IE versions except 11 to calculate percentages of p…
107fe4d 
…lugins

In piwik.js we exclude IE browsers by using the `MSIE` string in the user agent. However IE11 doesn't use that user agent anymore, which means we record plugin usage for IE11, which lead to % > 100%. Now we exclude only IE6, 7, 8, 9, 10.
@mnapoli
#7437 Prevent percentages to go over 100% for browser plugin support
206660b
@mnapoli mnapoli added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 18, 2015
@mnapoli mnapoli added this to the Piwik 2.12.0 milestone Mar 18, 2015
@mnapoli mnapoli mentioned this pull request Mar 18, 2015
Closed
mattab pushed a commit that referenced this pull request Mar 18, 2015
Merge pull request #7469 from piwik/browser_plugin_percentage_fix
5ab871c 
Percentage fix in the "Browser plugin" report
@mattab mattab merged commit 5ab871c into master Mar 18, 2015
@mnapoli mnapoli deleted the browser_plugin_percentage_fix branch March 18, 2015 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnapoli @mattab