Various performance improvements and bugfixes. #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imporves performance for Archiving and Range dates. Makes all kind of reports faster as well. Fixed bugs in labelFilter, reports total calculation and more.
tsteur
added
the
Pull Request WIP
| @@ -120,6 +121,7 @@ private function getGenericFiltersHavingDefaultValues() | |||
| foreach ($filters as $index => $filter) { | |||
| if ($filter[0] === 'Sort') { | |||
| $filters[$index][1]['filter_sort_column'] = array('string', $this->report->getDefaultSortColumn()); | |||
| $filters[$index][1]['filter_sort_order'] = array('string', $this->report->getDefaultSortOrder()); | |||
There was a problem hiding this comment.
Reports need to be able to specify a default sort order. Eg when defaultSortOrder should be label, asc
| @@ -90,6 +90,6 @@ | |||
| <reportTotal> | |||
| <nb_visits>8</nb_visits> | |||
| <nb_hits>13</nb_hits> | |||
| <exit_nb_visits>1</exit_nb_visits> | |||
| <exit_nb_visits>2</exit_nb_visits> | |||
There was a problem hiding this comment.
Another example where one can see that it fixes report total calculation as mentioned before.
tsteur
added
Needs Review
|
Looks good to me 👍 merging |
mattab
pushed a commit
that referenced
this pull request
Mar 18, 2015
Various performance improvements and bugfixes.
mattab
added a commit
that referenced
this pull request
Mar 18, 2015
mattab
added
the
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #4768 #7388 #6763
Improves performance for
Fixed bugs in LabelFilter, ReportsTotalCalculation, Sort and more.
A new feature is that we do now actually sort API output by
nb_visits, labelsby default which was often not the case. Also we do now sort by labels if both columns do not have a value. Eg if two rows do not havenb_visitsor any otherfilter_sort_columnthen the order was random. We do now sort by label in such a case.I didn't create a pull request for each fix separately since they only shows after tweaking some code and where not really visible before.
A few UI tests fail since we do now sort by label if two rows have both no value set. See eg http://builds-artifacts.piwik.org/ui-tests.datatable_tweaks/11069.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/PivotByDimension_pivoted.png&expected=PivotByDimension_pivoted.png&github=PivotByDimension_pivoted.png
For more information see my comments in the code. It would be kinda nice to have this in 2.12.0 since it brings many performance improvements.