@tsteur opened this Pull Request on March 18th 2015 Member

refs #4768 #7388 #6763

Improves performance for

  • Archiving (especially month, year archiving but as well archiving other blob records)
  • Range dates
  • Labelfilter
  • Should make all kind of reports faster as well but not as much

Fixed bugs in LabelFilter, ReportsTotalCalculation, Sort and more.

A new feature is that we do now actually sort API output by nb_visits, labels by default which was often not the case. Also we do now sort by labels if both columns do not have a value. Eg if two rows do not have nb_visits or any other filter_sort_column then the order was random. We do now sort by label in such a case.

I didn't create a pull request for each fix separately since they only shows after tweaking some code and where not really visible before.

A few UI tests fail since we do now sort by label if two rows have both no value set. See eg http://builds-artifacts.piwik.org/ui-tests.datatable_tweaks/11069.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/PivotByDimension_pivoted.png&expected=PivotByDimension_pivoted.png&github=PivotByDimension_pivoted.png

For more information see my comments in the code. It would be kinda nice to have this in 2.12.0 since it brings many performance improvements.

@mattab commented on March 18th 2015 Member

Looks good to me :+1: merging

This Pull Request was closed on March 18th 2015
Powered by GitHub Issue Mirror