Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make titles black instead of brown #7449

Closed
mattab opened this issue Mar 16, 2015 · 2 comments
Closed

Make titles black instead of brown #7449

mattab opened this issue Mar 16, 2015 · 2 comments
Assignees
@mnapoli
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.13.0

Comments

@mattab
Copy link
Member

mattab commented Mar 16, 2015

The goal of this issue is to make all titles in Piwik black colors, in particular to change the titles currently brown to make them consistent black.

For example: https://raw.githubusercontent.com/piwik/piwik-ui-tests/master/CoreUpdaterDb_main.png

also this: https://github.com/piwik/piwik-ui-tests/blob/master/UIIntegrationTest_goals_overview.png

They look quite wrong Imo so this is the reason to change them :-)
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Mar 16, 2015
@mattab mattab added this to the Piwik 2.13.0 milestone Mar 16, 2015
@mnapoli mnapoli self-assigned this Mar 22, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Mar 22, 2015

They are a different color because they are links. If we make them black we can see that they are link, but I tried in blue and that's too much IMO. I think black is good.

mnapoli added a commit that referenced this issue Mar 23, 2015
@mnapoli
#7449 Simplified and more consistent header's CSS (no more black or b…
a3a0f39 
…lue)
@mnapoli
Copy link
Contributor

mnapoli commented Mar 23, 2015

I have fixed this in #7481

I know ideally it should be a separate pull request but #7481 carries changes to uniformise base CSS styles (e.g. for headers) so it would be really more complex to make a separate pull request. I have taken the opportunity to simplify headers style: now Morpheus defines a base h2/h3 style consistent for all Piwik and CoreHome only overrides what's necessary for the h2 and h3 in reports (previously CoreHome was applying it style across all plugins & pages which was wrong). Much nicer, easier to theme, etc...

mnapoli added a commit that referenced this issue Mar 24, 2015
@mnapoli
#7449 Simplified and more consistent header's CSS (no more black or b…
ff9f3f7 
…lue)
mnapoli added a commit that referenced this issue Mar 30, 2015
@mnapoli
#7449 Simplified and more consistent header's CSS (no more black or b…
a5bc59a 
…lue)
mnapoli added a commit that referenced this issue Apr 15, 2015
@mnapoli
#7449 Simplified and more consistent header's CSS (no more black or b…
defd7f5 
…lue)
@mnapoli mnapoli closed this as completed Apr 17, 2015
@mattab mattab mentioned this issue Apr 21, 2015
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli