Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude extensions as downloads #7444

Closed
RMastop opened this issue Mar 16, 2015 · 1 comment
Closed

Exclude extensions as downloads #7444

RMastop opened this issue Mar 16, 2015 · 1 comment
Assignees
@sgiehl
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.13.0

Comments

@RMastop
Copy link
Contributor

RMastop commented Mar 16, 2015

We have a webservice that uses .exe in the URL. These calls is always tracked as a download.
Would love to see a per site setting to exclude / include extensions as a download.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Mar 16, 2015
@tsteur
Copy link
Member

tsteur commented Mar 16, 2015

Maybe we should add a new method to the Piwik.js tracker as this is detected on the client side. We won't be able to add a setting there. There are already the following methods:

  • setDownloadExtensions(extensions)
  • addDownloadExtensions(extensions)

Maybe we could add a method removeDownloadExtensions. This would allow to do the following:

_paq.push(['removeDownloadExtensions', 'exe']);
_paq.push(['removeDownloadExtensions', 'exe|dmg']);

If someone is working on this anyway, maybe that person can also change those 3 methods to accept an array of extensions as well. Currently, one needs to separate them by a | which is not really user friendly and it doesn't allow us to change the internal handling.

sgiehl added a commit that referenced this issue Apr 5, 2015
@sgiehl
fixes #7444 - allow removing download extensions
46d1825
@sgiehl sgiehl self-assigned this Apr 5, 2015
@sgiehl sgiehl mentioned this issue Apr 5, 2015
Merged
sgiehl added a commit that referenced this issue Apr 7, 2015
@sgiehl
refs #7444 - added js tests
0ff9266
@mattab mattab added this to the Piwik 2.13.0 milestone Apr 8, 2015
mattab pushed a commit that referenced this issue Apr 9, 2015
Merge pull request #7629 from piwik/7444
2bbfc4d 
Allow removing download extensions (fixes #7444)
@sgiehl sgiehl mentioned this issue Apr 17, 2015
Closed
@sgiehl sgiehl mentioned this issue Apr 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
4 participants
@tsteur @mattab @sgiehl @RMastop