Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popovers should not open on login page #7431

Closed
sgiehl opened this issue Mar 14, 2015 · 1 comment
Closed

Popovers should not open on login page #7431

sgiehl opened this issue Mar 14, 2015 · 1 comment
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.12.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Mar 14, 2015

When opening a direct link to a visitor profile with not having access to it ends up on the login page showing an popover loading the login page with another popover and so on.

See http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=34&period=day&date=yesterday#/module=Live&action=indexVisitorLog&idSite=34&period=day&date=yesterday&popover=visitorProfile$3Ae02fb30d85e6d686

Instead only the login page should load.
@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 14, 2015
@sgiehl sgiehl self-assigned this Mar 14, 2015
@sgiehl sgiehl added this to the Piwik 2.12.0 milestone Mar 14, 2015
@sgiehl sgiehl added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Mar 14, 2015
@sgiehl sgiehl changed the title Popovers should not open without access Popovers should not open on login page Mar 14, 2015
@sgiehl sgiehl closed this as completed in 649337c Mar 14, 2015
@mattab
Copy link
Member

mattab commented Mar 16, 2015

Nice find 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
2 participants
@mattab @sgiehl