Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to visitor log #7430

Merged
merged 10 commits into from Mar 30, 2015
Merged

Improvements to visitor log #7430

merged 10 commits into from Mar 30, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 14, 2015

This PR aims to fix #6176

Currently the visitor log looks like that:

visitorlog_before

As the browser plugins are not relevant for every one and some users asked to have the full location information instead, I now added the possibility to see all information. I've also added a new icon for the device type. Overall it now looks like that:

visitorlog_after

By default only the icons are displayed without any additional informationen. But it is now possible to hover the small icons to see more information:

visitorlog_flag_hovervisitorlog_browser_hovervisitorlog_device_hover

In order to have all information available in the visitor log, I had to adjust the information available in the visitor details. They now additionally contain deviceTypeIcon, deviceBrand and deviceModel

@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 14, 2015
mnapoli
mnapoli reviewed Mar 15, 2015
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,7 @@ This is a changelog for Piwik platform developers. All changes for our HTTP API'
## Piwik 2.12.0

### Breaking Changes
* Visitor details now additionally contain: `deviceTypeIcon`, `deviceBrand` and `deviceModel`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a breaking change or rather an improvement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more an improvement. But I thought it would be worth mentioning in changelog and we didn't have another headline it would fit in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe create a new headline eg. APIs Improvements ?

@mnapoli
Copy link
Contributor

mnapoli commented Mar 15, 2015

That's a really cool improvement!

@mattab
Copy link
Member

mattab commented Mar 16, 2015

Nice improvements!

  • +1 for the new icon for device type
  • +1 for hiding the plugin icons (too much noise!)
  • +1 for more information (ie. full information!) to the user on request (that's really great and part of our vision to give users all the data when they need it, and not hide anything from them)
  • -1 for "transparent" icons - can we try with the full opacity icons instead?

BTW it's very good to improve the Visitor Log in general, because that's one of the most used and loved features in Piwik :-)

@mattab mattab added this to the Piwik 2.13.0 milestone Mar 16, 2015
@sgiehl
Copy link
Member Author

sgiehl commented Mar 16, 2015

@mattab Ok. I've adjusted the changelog and moved it to new topic "API Improvements" for Piwik 2.13.
Regarding the "transparent" icons: The opacity is removed on hover, so the user get's a little feedback that something is happening. But that could be removed for sure, or should I just increase the opacity value. It currently starts at 0.5. Do you think starting at 0.7 would be better?

@mattab
Copy link
Member

mattab commented Mar 16, 2015

I think it's better to remove the opacity... if we wanted to show feedback on hover...

  1. maybe we could use the existing UI pattern on the Report footer icons, ie. add a grey background behind the icon. I guess it may look bad because many Visitor log icons don't have transparent background....
  2. Another idea would be to draw a thin border on hover

@sgiehl
Copy link
Member Author

sgiehl commented Mar 17, 2015

Ok. I've removed the opacity. Adding border or grey background didn't look very good, cause of different icon sizes

@mattab
Copy link
Member

mattab commented Mar 18, 2015

Here is feedback looking at UI tests:

  • the "Goal conversion" icon (flag) is pushed out of display sometimes (not a regression). Can we add a linebreak before showing this icon to give it full display? eg. this ui test
  • could we make the popover a bit wider by default? (general issue in piwik)

@sgiehl
Copy link
Member Author

sgiehl commented Mar 22, 2015

I've tried to fix the layout problem with the icons. Let's see if the ui tests look better now :)
Regarding the Popovers: Maybe we should open another issue for that, as that will break more ui tests.

@mattab mattab mentioned this pull request Mar 23, 2015
Closed
@mattab
Copy link
Member

mattab commented Mar 23, 2015

Regarding the Popovers: Maybe we should open another issue for that, as that will break more ui tests.

Sure it is: #7517

@mattab
Copy link
Member

mattab commented Mar 30, 2015

Looks good to me! we'll need to update screenshot tests as the UI build failed in the PR

mattab pushed a commit that referenced this pull request Mar 30, 2015
Merge pull request #7430 from piwik/6176
873fb6f 
Improvements to visitor log
@mattab mattab merged commit 873fb6f into master Mar 30, 2015
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Mar 30, 2015
@mnapoli mnapoli deleted the 6176 branch March 31, 2015 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @mnapoli @mattab