Ability to sync UI screenshots for Plugins including premium plugins #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
not-in-changelog
| * @param OutputInterface $output | ||
| */ | ||
| protected function displayGitInstructions(OutputInterface $output) | ||
| protected function displayGitInstructions(InputInterface $input, OutputInterface $output) |
There was a problem hiding this comment.
Small detail: you might want to get $plugin and pass it to this function instead of InputInterface. This would keep the argument/option reading in one place.
(Alt text: maybe you could pass the $plugin into this function instead of InputInterface? then the argument/option reading would be in one place.)
… hold state in object, better message to developer
mattab
pushed a commit
that referenced
this pull request
Mar 16, 2015
Ability to sync UI screenshots for Plugins including premium plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7393
updated wiki at: https://github.com/PiwikPRO/support/wiki/How-to-develop-PRO-plugins%3F