Made reports faster when flat=1 is used. #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaceColumnNames is now queued again which should bring a performance boost in general.
| @@ -337,6 +323,36 @@ public function getSocials($idSite, $period, $date, $segment = false, $expanded | |||
| $this->setSocialIdSubtables($dataTable); | |||
| $this->removeSubtableMetadata($dataTable); | |||
|
|
|||
| if ($flat) { | |||
| $urlsTable = Archive::createDataTableFromArchive(Archiver::WEBSITES_RECORD_NAME, $idSite, $period, $date, $segment, $expanded, $flat); | |||
There was a problem hiding this comment.
Here we need a special handling to make it fast as getSocials does not really have a subtable...
There was a problem hiding this comment.
can you refactor this special handling in own method?
(or maybe even own filter if it makes sense)
| if (Common::getRequestVar('flat', 0, 'int') === 1) { | ||
| $view->requestConfig->filter_excludelowpop = 'nb_hits'; | ||
| } else { | ||
| $view->requestConfig->filter_excludelowpop = Metrics::INDEX_PAGE_NB_HITS; |
There was a problem hiding this comment.
un-related to this PR, but +1 toconsider removing this mix of Metrics ID and Named metrics... could you create an issue for this? (to store named metrics in archives rather than stored metrics ID)
|
Feedback
|
mattab
pushed a commit
that referenced
this pull request
Mar 12, 2015
Made for reports faster when flat=1 is used.
mattab
changed the title
mattab
added
the
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
replaceColumnNamesis now queued again which should bring a performance boost in general for not flattened and not expanded reports.Eg in my dev vm A huge first level
getPageUrlsreport loads in < 300ms. Half of that time is spent in Twig, about 1/4 in bootstrapping etc. We do now spend more time in JS (300-400ms on a fast computer with a fast browser) after the report is fetched than it takes to fetch it.