Dependency injection in API classes #7407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added
Enhancement
|
Re: |
|
👍 for DI! |
|
Good point! They are only used in tests except in the LanguagesManager to "clear the cache" basically so this could be replaced by something better. I've added the deprecations. |
|
Looks good to me! +1 to deprecate unsetInstance/ setSingletonInstance and remove it in couple months. (I noticed there are protected constructors in InterSites and CustomAlerts maybe those can be changed after PR is merged) |
mnapoli
added a commit
that referenced
this pull request
Mar 17, 2015
Dependency injection in API classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the ability to use dependency injection in API classes.
This also registers API classes in the container (so these classes can be injected), though they are still singletons. The problem is that the singleton pattern in Piwik also offers
unsetInstance()andsetSingletonInstance()and I think this would mess up with the container, but since those should only be used in tests (right?) we should be fine and be able to fix it easily.